高并發(fā)下論壇間歇性出現(xiàn)(Discuz! Database Error)Bug修復

discus999

Bug：高并發(fā)下，pre_common_session會員認證表的delete操作表鎖沖突導致數(shù)據(jù)庫連接數(shù)耗盡，適用X3.2、X3.4


Fix：
public function delete_by_session($session, $onlinehold, $guestspan) {
        if(!empty($session) && is_array($session)) {
                $onlinehold = time() - $onlinehold;
                $guestspan = time() - $guestspan;
                $session = daddslashes($session);


                $condition = " sid='{$session[sid]}' ";
                $condition .= " OR lastactivity<$onlinehold ";
                $condition .= " OR (uid='0' AND ip1='{$session['ip1']}' AND ip2='{$session['ip2']}' AND ip3='{$session['ip3']}' AND ip4='{$session['ip4']}' AND lastactivity>$guestspan) ";
                $condition .= $session['uid'] ? " OR (uid='{$session['uid']}') " : '';
                //DB::delete('common_session', $condition);
               //fix by wangxj
                $query = DB::query("SELECT sid FROM ".DB::table('common_session')." WHERE $condition");
                $sids = array();
                while ($row = DB::fetch($query)) {
                        $sids[] = $row['sid'];
                }
                // 按主鍵sid刪除
                if (!empty($sids)) {
                        DB::delete('common_session', DB::field('sid', $sids));
                }
        }
}